wgtmac commented on code in PR #3753:
URL: https://github.com/apache/parquet-java/pull/3753#discussion_r4084195011
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java:
##########
@@ -230,4 +240,67 @@ private GenericData getDataModel(ParquetConfiguration
conf, Schema schema) {
return ReflectionUtils.newInstance(suppClass,
ConfigurationUtil.createHadoopConfiguration(conf))
.get();
}
+
+ // Creates a copy of the user's Configuration with derived list encoding
properties
+ private static ParquetConfiguration getDerivedListEncodingConf(
+ ParquetConfiguration configuration, MessageType fileSchema) {
+ Configuration copiedConfiguration =
+ new
Configuration(ConfigurationUtil.createHadoopConfiguration(configuration));
Review Comment:
Could we reuse the original ParquetConfiguration when no list settings need
to be inferred? When inference is needed, do we have to convert it to a Hadoop
Configuration and back? AvroSchemaConverter already accepts
ParquetConfiguration, so this seems to reintroduce a Hadoop dependency after
the earlier decoupling work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
