divjotarora commented on code in PR #3711:
URL: https://github.com/apache/parquet-java/pull/3711#discussion_r3971241383
##########
parquet-column/src/main/java/org/apache/parquet/schema/Types.java:
##########
@@ -590,9 +632,15 @@ public Optional<Boolean> visit(
return checkBinaryPrimitiveType(geographyLogicalType);
}
+ private void checkAnnotation(boolean valid, String message,
Object... args) {
Review Comment:
Fair point, I was trying to make the minimal code change but I agree it was
a bad abstraction. The structure you're proposing is similar to Arrow C++ and I
think it's better. Will take a stab at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
