RussellSpitzer commented on code in PR #3711:
URL: https://github.com/apache/parquet-java/pull/3711#discussion_r3971270233
##########
parquet-column/src/main/java/org/apache/parquet/schema/Types.java:
##########
@@ -590,9 +632,15 @@ public Optional<Boolean> visit(
return checkBinaryPrimitiveType(geographyLogicalType);
}
+ private void checkAnnotation(boolean valid, String message,
Object... args) {
Review Comment:
Yeah, Sometimes I think it's just worth pulling the trigger and doing it the
right way. You definitely had the smallest change version here, but I think it
becomes dangerous for leaking cases (like the decimal one above) because
everything keeps going through different paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
