stevenwarejones commented on code in PR #3785: URL: https://github.com/apache/parquet-java/pull/3785#discussion_r3980964404
########## parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KmsClientFactory.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.parquet.crypto.keytools; + +/** Factory for creating {@link KmsClient} instances with programmatically supplied dependencies. */ +@FunctionalInterface +public interface KmsClientFactory { + + /** + * Creates a KMS client. {@link KeyToolkit} initializes the returned client before using it. + * + * @return a new or pre-built KMS client + */ + KmsClient createKmsClient(); Review Comment: Done. I went slightly further and now pass the full creation context: `Configuration`, KMS instance ID, KMS instance URL, and access token. That lets an immutable or constructor-injected implementation select dependencies using the resolved values before `initialize` is called. I also documented that each factory invocation must return a distinct, uninitialized client, since the factory is invoked separately for uncached token/KMS-instance combinations. Tests now verify the complete context and separate initialized clients for two access tokens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
