stevenwarejones commented on code in PR #3785:
URL: https://github.com/apache/parquet-java/pull/3785#discussion_r4000780010
##########
parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyToolkit.java:
##########
@@ -109,13 +117,21 @@ public class KeyToolkit {
// KMS client two level cache: token -> KMSInstanceId -> KmsClient
static final TwoLevelCacheWithExpiration<KmsClient>
KMS_CLIENT_CACHE_PER_TOKEN = KmsClientCache.INSTANCE.getCache();
- // KEK two level cache for wrapping: token -> MEK_ID -> KeyEncryptionKey
- static final TwoLevelCacheWithExpiration<KeyEncryptionKey>
KEK_WRITE_CACHE_PER_TOKEN =
+ // KEK cache for wrapping: token -> KMS instance ID -> master key ID ->
KeyEncryptionKey
+ static final TwoLevelCacheWithExpiration<ConcurrentMap<String,
KeyEncryptionKey>> KEK_WRITE_CACHE_PER_TOKEN =
Review Comment:
What if I scope the KMS-instance cache change to factory registrations and
leave the legacy reflective cache unchanged, or do you have concerns about the
factory-specific change as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
