vinooganesh commented on PR #3397: URL: https://github.com/apache/parquet-java/pull/3397#issuecomment-5653117709
Opened #3791 as the thrift precursor for this PR. It bumps the inlined `parquet.thrift` from parquet-format 2.13.0 to 2.14.0 using `dev/update-parquet-thrift.sh`, which is a released tag containing ALP, so the entry comes from upstream rather than being hand written here. One thing worth knowing, since it changes the shape of what was suggested. The bump cannot be thrift only: on a clean master it fails `testEnumEquivalence` with `No enum constant org.apache.parquet.column.Encoding.ALP`, because the generated format enum gains ALP(10) while the hand written `column.Encoding` has none, and adding that constant pulls in the ALP readers with it. So #3791 carries a temporary skip for ALP, which this PR removes. Once #3791 merges I will rebase this one and drop the local `ALP = 10` block, the "LOCAL ADDITION" notice, and that skip. The bump also brings the FILE logical type and INT96 chronological ordering, neither of which needs Java side handling beyond one guard so a FILE annotated column keeps degrading to its physical type instead of throwing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
