vinooganesh commented on PR #3397: URL: https://github.com/apache/parquet-java/pull/3397#issuecomment-5686025101
@RussellSpitzer with #3791 merged, I've merged master in and worked through what was left of your nits: - **Thrift**: the inlined `parquet.thrift` is the upstream 2.14.0 file, so the local addition is gone. - **Skips**: the `testEnumEquivalence` ALP skip is gone again (7b48dd189), after the merge reintroduced it. - **Javadocs**: I grepped again for anything describing ALP as not yet upstream. The only thing left was a `@see` to parquet-testing#100, which has since been closed in favour of #119, so I dropped it. - **`withoutAlp(column)`**: in a8c584f64, as before. One question from last time is still open: `TestInterOpReadAlp` skips when pyarrow reports "Unknown encoding type". Happy to pull it if you'd rather it fail loudly. Your approval is against e660c6cec, so another look whenever you get a chance would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
