divjotarora commented on PR #3848: URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6124656561
The changes themselves LGTM but I agree with @wgtmac's question on whether such tests are necessary. Can we write a more concise set of 1-2 tests to validate basic functionality instead? Also, is the exact wording from CLI output considered a stable API? If not, these tests are brittle and I'm not sure what exact contract they're testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
