divjotarora commented on PR #3848: URL: https://github.com/apache/parquet-java/pull/3848#issuecomment-6141038170
> > Reduced to two smoke tests in [59c5aab](https://github.com/apache/parquet-java/commit/59c5aab6c7e624eff3c165f23ed60997564bb94a): version output and unknown-command failure, without asserting help or error wording. > > Thinking about it more, these two tests may not justify a separate PR. I'd lean toward closing this and focusing on command options reaching the actual logic, as outlined in the [tracker](https://github.com/apache/parquet-java/issues/3289#issuecomment-6031117043). Let me know your thoughts. I'll defer to @wgtmac here. IMO this doesn't need a separate PR. If we're just adding tests, my preference is a smaller set of bigger PRs rather than a large set of tiny ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
