Devdha commented on PR #3880: URL: https://github.com/apache/parquet-java/pull/3880#issuecomment-6432826269
Follow-up after an independent review: brotli4j 1.24.0 has a known streaming-decoder bug (hyperxpro/Brotli4j#267) that produces `unexpected end of input` for valid streams once the output crosses the 4 MiB window. I reworked `BrotliCompressionInputStream` to use the one-shot `Decoder.decompress(byte[])` for the page-sized input Parquet provides, added a 5 MiB regression test, and fixed the Hadoop stream contract issues found during review (`close()` now closes the caller target, `flush()` flushes the encoder, failed `finish()` is not silently retried). Default quality is back to 1, matching the previous codec and Parquet docs. Tests: `TestBrotliCodec` 6 passed, `TestDirectCodecFactory.compressionCodecs` 1 passed, and `package` succeeds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
