Devdha commented on PR #3880: URL: https://github.com/apache/parquet-java/pull/3880#issuecomment-6434226918
Opus 5.5 review via Claude Code found two additional blockers, now fixed in `d9f8a1d`: 1. The first one-shot rewrite used the unbounded `Decoder.decompress` overload. A small page could expand without limit and OOM the reader before the page-header size was checked. Switched to the bounded 4-argument decoder and pass the page's declared uncompressed size from `CodecFactory`; the generic path has a finite cap. Added a compression-bomb regression test. 2. `spotless:check` failed on three files; applied `spotless:apply`. Also addressed the review's should-fix items: the large `CodecFactory` test now uses quality 5 (quality 1 did not reproduce #267), `flush()` now flushes the target too, `resetState()` no longer replays stale data, quality validation moved from `setConf` to the write path, and `close()` is idempotent after a failure. PR body corrected (no OSGi plugin is involved; aarch64 was local only; the decoder call is the 4-arg API). Tests: 8 + 1 passed, `spotless:check` passed, `package` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
