manuzhang opened a new pull request, #3931:
URL: https://github.com/apache/parquet-java/pull/3931
### Rationale for this change
The release commit 490699b8 ("Set version to 1.18.2 for release"), which is
the current head of `parquet-1.18.x`, did more than bump the 18 POM versions.
It also committed `thrift-0.25.0/`: 3,550 files (about 332 MB unpacked),
including 40 compiled x86-64 `.o` files and the files Thrift's `configure`
generates. The prepare-RC workflow had built Thrift inside the checkout, and
`prepare-rc.sh` staged the version bump with `git add -A`. The tree ended up in
the 1.18.2-rc0 source tarball (72.6 MB, against 1.4 MB for 1.18.1), so RC0
cannot be released.
### What changes are included in this PR?
- `git revert 490699b8`. The branch tree becomes identical to 9ea3b783 (`git
diff 9ea3b783 HEAD` is empty), with the POMs back at `1.18.2-SNAPSHOT`.
The next prepare-RC run will make a fresh "Set version to 1.18.2 for
release" commit. That run uses the same `git add` step that caused this, so
**#3929 (the workflow fix on `master`) must be merged first**. #3929 builds
Thrift outside the checkout, stages with `git add -u`, and refuses to tag a
working tree with untracked files.
This supersedes #3930, which removed only `thrift-0.25.0/` and kept the POMs
at 1.18.2.
The removed files stay in history through 490699b8 and the
`apache-parquet-1.18.2-rc0` tag, but they are no longer in the tree RC1 will be
built from.
### Are these changes tested?
- `git diff 9ea3b783 HEAD` is empty, so the tree matches the commit before
the release bump, which already passed CI.
### Are there any user-facing changes?
No.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
