[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567346#comment-16567346
]
ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/315
> The setup of GlobalClientMetrics just... doesn't give us any way to do
this nicely
Yes, agreed on that one.
> I'm not sure what it takes to write a custom Factory (I think I did it
once in an IT), but would be OK if you defer this
Checkout `PhoenixMetricsDisabledIT` in this patch. I am doing the same.
> After you commit this, please update the website with these necessary
changes (e.g. at least tell people that PQS exports metrics).
Sure will file a new Jira for documentation change as well.
One last question, Is it fine for me to change the `QueryServer#main()` to
use `HBaseFactoryProvider.getConfigurationFactory().getConfiguration()` instead
of the regular one. We can control the config from other projects, if required.
What do you think?
> Global Phoenix Client Metrics for PQS
> -------------------------------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Reporter: Rahul Shrivastava
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf,
> PHOENIX-3655.4.x-HBase-1.4.001.patch
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
