[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567366#comment-16567366
]
ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/315
> I'd just leave this as-is for now. I don't think it's "broken" how it is
right now (PQS doesn't try to set anything in the Configuration for the
PhoenixDriver to pick up).
It's just that some project using PQS wants to change configuration via
code, It wont be possible since `HBaseConfiguration.create()` will only read
XML on the class path. Either way, I am fine. Let me know your thoughts.
> Global Phoenix Client Metrics for PQS
> -------------------------------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Reporter: Rahul Shrivastava
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf,
> PHOENIX-3655.4.x-HBase-1.4.001.patch
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
