[
https://issues.apache.org/jira/browse/PHOENIX-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567626#comment-16567626
]
Hadoop QA commented on PHOENIX-4799:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12934188/PHOENIX-4799-v4.patch
against master branch at commit 4a9e5be82db18d942f365370abe4a3104780eea8.
ATTACHMENT ID: 12934188
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[57,8]
org.apache.phoenix.query.DelegateConnectionQueryServices is not abstract and
does not override abstract method
deleteMutexCell(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
in org.apache.phoenix.query.ConnectionQueryServices
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[375,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[380,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[109,8]
org.apache.phoenix.query.ConnectionlessQueryServicesImpl is not abstract and
does not override abstract method
deleteMutexCell(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
in org.apache.phoenix.query.ConnectionQueryServices
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[746,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[751,5]
method does not override or implement a method from a supertype
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.0:compile (default-compile) on
project phoenix-core: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[57,8]
org.apache.phoenix.query.DelegateConnectionQueryServices is not abstract and
does not override abstract method
deleteMutexCell(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
in org.apache.phoenix.query.ConnectionQueryServices
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[375,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/DelegateConnectionQueryServices.java:[380,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[109,8]
org.apache.phoenix.query.ConnectionlessQueryServicesImpl is not abstract and
does not override abstract method
deleteMutexCell(java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)
in org.apache.phoenix.query.ConnectionQueryServices
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[746,5]
method does not override or implement a method from a supertype
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build@2/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java:[751,5]
method does not override or implement a method from a supertype
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1957//console
This message is automatically generated.
> Write cells using checkAndMutate to prevent conflicting changes
> ---------------------------------------------------------------
>
> Key: PHOENIX-4799
> URL: https://issues.apache.org/jira/browse/PHOENIX-4799
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Attachments: PHOENIX-4799-v2.patch, PHOENIX-4799-v3.patch,
> PHOENIX-4799-v4-4.x-HBase-1.3.patch, PHOENIX-4799-v4.patch
>
>
> In order to prevent race conditions when multiple client try to mutate the
> same column before sending the request to mutate the column to the server do
> a checkAndMutate with the column name being added/dropped. Also:
> 1. When a view is created do a checkAndMutate with the columns in the view
> where clause.
> 2. When an index on a view is created do a checkAndMutate with the indexed
> columns.
>
> To prevent a race condition in the DROP TABLE CASCADE case, when a table is
> dropped do a checkAndMutate with the rowkey of the base table name. If a view
> is created it also does a checkAndMutate with the same rowkey.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
