[
https://issues.apache.org/jira/browse/PHOENIX-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569041#comment-16569041
]
Hadoop QA commented on PHOENIX-4799:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12934312/PHOENIX-4799-v6-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
2379080d8348f7f9953c5ab95bdb473ab326b5c3.
ATTACHMENT ID: 12934312
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ conn.createStatement().execute("ALTER TABLE " + tableName
+ " ADD VIEW_COL1 DECIMAL(10,2) PRIMARY KEY, VIEW_COL2 VARCHAR(256) PRIMARY
KEY");
+ "SYSTEM:CATALOG", "SYSTEM:SEQUENCE", "SYSTEM:STATS",
"SYSTEM:FUNCTION", "SYSTEM:MUTEX"));
+ verifyAllowed(grantPermissions("RWX", user,
SYSTEM_SEQUENCE_IDENTIFIER, false), superUser);
+
.acquireUpgradeMutex(MetaDataProtocol.MIN_SYSTEM_TABLE_MIGRATION_TIMESTAMP));
+ grantPermissions(regularUser1.getShortName(),
Collections.singleton("SYSTEM:MUTEX"), Action.WRITE,
+ grantPermissions(unprivilegedUser.getShortName(),
Collections.singleton("SYSTEM:MUTEX"), Action.WRITE,
+ grantPermissions(regularUser1.getShortName(),
Collections.singleton("SYSTEM.MUTEX"), Action.WRITE,
+ grantPermissions(unprivilegedUser.getShortName(),
Collections.singleton("SYSTEM.MUTEX"), Action.WRITE,
+ assertTableMetaData(rs,
PhoenixDatabaseMetaData.SYSTEM_CATALOG_SCHEMA,
PhoenixDatabaseMetaData.SYSTEM_MUTEX_TABLE_NAME, PTableType.SYSTEM);
+ serverProps.put("hbase.coprocessor.region.classes",
TestMetaDataRegionObserver.class.getName());
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1961//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1961//console
This message is automatically generated.
> Write cells using checkAndMutate to prevent conflicting changes
> ---------------------------------------------------------------
>
> Key: PHOENIX-4799
> URL: https://issues.apache.org/jira/browse/PHOENIX-4799
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Priority: Major
> Attachments: PHOENIX-4799-v2.patch, PHOENIX-4799-v3.patch,
> PHOENIX-4799-v4-4.x-HBase-1.3.patch, PHOENIX-4799-v4.patch,
> PHOENIX-4799-v5-4.x-HBase-1.3.patch, PHOENIX-4799-v5.patch,
> PHOENIX-4799-v6-4.x-HBase-1.3.patch, PHOENIX-4799-v6.patch
>
>
> In order to prevent race conditions when multiple client try to mutate the
> same column before sending the request to mutate the column to the server do
> a checkAndMutate with the column name being added/dropped. Also:
> 1. When a view is created do a checkAndMutate with the columns in the view
> where clause.
> 2. When an index on a view is created do a checkAndMutate with the indexed
> columns.
>
> To prevent a race condition in the DROP TABLE CASCADE case, when a table is
> dropped do a checkAndMutate with the rowkey of the base table name. If a view
> is created it also does a checkAndMutate with the same rowkey.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
