[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571939#comment-16571939
]
Karan Mehta commented on PHOENIX-4834:
--------------------------------------
Thanks [~elserj]. That makes things easier for me. Will upload a new patch soon.
> PhoenixMetricsLog interface methods should not depend on specific logger
> ------------------------------------------------------------------------
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
