[
https://issues.apache.org/jira/browse/PHOENIX-4834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583122#comment-16583122
]
ASF GitHub Bot commented on PHOENIX-4834:
-----------------------------------------
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/phoenix/pull/327
PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on…
… specific logger
@ankitsinghal I did some refactoring in tests and added new tests for the
scenario along with now logging metrics both on close and commit. Hence, a
quick look at PR would be helpful.
There is one more small pending problem, metrics won't be logged when
auto_commit is set to true. Will file a separate Jira for that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanmehta93/phoenix 4.x-HBase-1.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #327
----
commit 6c95b6d5fe308d85a17709db50493dfa6a61628b
Author: Karan Mehta <karanmehta93@...>
Date: 2018-08-16T22:08:12Z
PHOENIX-4834 PhoenixMetricsLog interface methods should not depend on
specific logger
----
> PhoenixMetricsLog interface methods should not depend on specific logger
> ------------------------------------------------------------------------
>
> Key: PHOENIX-4834
> URL: https://issues.apache.org/jira/browse/PHOENIX-4834
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4834.4.x-HBase-1.4.001.patch,
> PHOENIX-4834.4.x-HBase-1.4.002.patch
>
>
> {{PhoenixMetricsLog}} is an interface that provides a wrapper around various
> JDBC objects with logging functionality upon close/commit. The methods take
> in {{Logger}} as an input, which is {{org.slf4j.Logger}}. A better way of
> doing is that the interface should just pass the metrics and allow the user
> to configure and use whatever logging library they want to use.
> This Jira will deprecate the older methods by provide a default
> implementation for them and add the new methods.
> Ideally we should have provided default implementations, but since we are on
> Java 7, we are unable to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
