Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/329#discussion_r211060422
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -3681,7 +3691,12 @@ public MutationState addColumn(PTable table, 
List<ColumnDef> origColumnDefs,
                 }
             } finally {
                 connection.setAutoCommit(wasAutoCommit);
    -            if (!acquiredColumnMutexSet.isEmpty()) {
    +            if (EncodedColumnsUtil.usesEncodedColumnNames(table)) {
    +                // release the mutex on the physical table (used to 
prevent concurrent conflicting
    +                // add column changes)
    +                deleteCell(null, physicalSchemaName, physicalTableName, 
null);
    --- End diff --
    
    should we check here that we have acquired the mutex?


---

Reply via email to