Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/338#discussion_r215432400
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java
---
@@ -62,4 +75,10 @@ public ResultSet getGeneratedKeys() throws SQLException {
return new LoggingPhoenixResultSet(super.getGeneratedKeys(),
phoenixMetricsLog, this.sql);
}
+ private void loggingAutoCommitHelper() throws SQLException {
+ if(conn instanceof LoggingPhoenixConnection &&
conn.getAutoCommit()){
--- End diff --
nit:
just change the order of conditions
add brackets around `conn instanceof LoggingPhoenixConnection`
and add spaces before brackets in conditions (applicable everywhere)
---
