[GitHub] phoenix pull request #338: PHOENIX-4870 LoggingPhoenixConnection should log ...

[karanmehta93]

Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/338#discussion_r215432867
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixLoggingMetricsIT.java
 ---
    @@ -164,13 +167,51 @@ public void testPhoenixMetricsLoggedOnClose() throws 
Exception {
                     mutationReadMetricsMap.size() == 0);
         }
     
    +
    +    @Test
    +    public void testPhoenixMetricsLoggedOnAutoCommitTrue() throws 
Exception {
    --- End diff --
    
    nit: just add a description of test above as javadoc comment


---