[
https://issues.apache.org/jira/browse/PHOENIX-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610137#comment-16610137
]
Hadoop QA commented on PHOENIX-4884:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12939192/PHOENIX-4884.004.patch
against master branch at commit 180b8ca38f64727b13f46f7e1a7db8b672d093c9.
ATTACHMENT ID: 12939192
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static Object evaluateExpression(String value, PDataType<?>
dataType, String strToSearch, SortOrder order) throws SQLException {
+ public static void inputExpression(String value, PDataType<?> dataType,
String strToSearch,Integer expected, SortOrder order) throws SQLException {
+ public static void inputNullExpression(String value, PDataType<?>
dataType, String strToSearch, SortOrder order) throws SQLException {
+ // Phoenix can't represent empty strings, so an empty or null search
string should return null
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ColumnEncodedMutableNonTxStatsCollectorIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2031//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2031//console
This message is automatically generated.
> INSTR function should work seamlessly with literal and non-literal arguments
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-4884
> URL: https://issues.apache.org/jira/browse/PHOENIX-4884
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4884.001.patch, PHOENIX-4884.002.patch,
> PHOENIX-4884.003.patch, PHOENIX-4884.004.patch
>
>
> INSTR's documentation reads as though it should support an expression or a
> literal for either argument. At least, it doesn't say that it only supports
> one or the other.
> However, the implementation only handles the case of {{INSTR(expr,
> literal)}}. We can pretty easily make this better and work with any
> combination:
> e.g. {{INSTR(literal, expr)}}, {{INSTR(expr, expr)}}, {{INSTR(literal,
> literal)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
