[ 
https://issues.apache.org/jira/browse/PHOENIX-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610369#comment-16610369
 ] 

Hudson commented on PHOENIX-4884:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #202 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/202/])
PHOENIX-4884 Update INSTR to handle literals and non-literals in either 
(elserj: rev 3b03e1b0bddaf3b52637187ff556fbb39b1dddef)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/InstrFunctionIT.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/expression/function/InstrFunctionTest.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/InstrFunction.java


> INSTR function should work seamlessly with literal and non-literal arguments
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-4884
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4884
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4884.001.patch, PHOENIX-4884.002.patch, 
> PHOENIX-4884.003.patch, PHOENIX-4884.004.patch
>
>
> INSTR's documentation reads as though it should support an expression or a 
> literal for either argument. At least, it doesn't say that it only supports 
> one or the other.
> However, the implementation only handles the case of {{INSTR(expr, 
> literal)}}. We can pretty easily make this better and work with any 
> combination:
> e.g. {{INSTR(literal, expr)}}, {{INSTR(expr, expr)}}, {{INSTR(literal, 
> literal)}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to