Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/309#discussion_r219293433
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
 ---
    @@ -371,20 +396,31 @@ public static void setUpsertStatement(final 
Configuration configuration, String
             }
             return selectColumnList;
         }
    -    
    +
         public static String getSelectStatement(final Configuration 
configuration) throws SQLException {
    +        return getSelectStatement(configuration, false);
    +    }
    +
    +    public static String getSelectStatement(final Configuration 
configuration,
    +            boolean isTargetStatement) throws SQLException {
             Preconditions.checkNotNull(configuration);
    -        String selectStmt = configuration.get(SELECT_STATEMENT);
    +        String selectKey = (isTargetStatement) ? SELECT_TARGET_STATEMENT : 
SELECT_STATEMENT;
    +        String selectStmt = configuration.get(selectKey);
             if(isNotEmpty(selectStmt)) {
    --- End diff --
    
    Please add a info LOG line here.


---

Reply via email to