Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/309#discussion_r219312456
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationSourceWritable.java
 ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you maynot use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicablelaw or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.mapreduce;
    +
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Map;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.phoenix.jdbc.PhoenixResultSet;
    +
    +/**
    + * DB Writable class extended for reading key/values for verify
    + * replication source
    + */
    +public class VerifyReplicationSourceWritable extends PhoenixRecordWritable 
{
    +    private ImmutableBytesWritable sourceKey;
    +    private Map<String, Object> sourceResults;
    +
    +    /** For serialization*/
    +    public VerifyReplicationSourceWritable() {
    +        super();
    +    }
    +
    +    public ImmutableBytesWritable getSourceKey() {
    +        return sourceKey;
    +    }
    +
    +    public Map<String, Object> getSourceResults() {
    +        return sourceResults;
    +    }
    +
    +
    +    @Override
    +    public void readFields(ResultSet resultSet) throws SQLException {
    --- End diff --
    
    I think you should add these changes to `PhoenixRecordWritable` directly. 
Should be a good addition over there.


---

Reply via email to