[
https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664442#comment-16664442
]
Hadoop QA commented on PHOENIX-4764:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12945647/0001-PHOENIX-4764-Revised-fix-based-on-the-review-comment.patch
against master branch at commit 4eba144c9bc650ebda3dbd341d036479b1c5f767.
ATTACHMENT ID: 12945647
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertFalse(stmt.execute(String.format("DROP TABLE IF
EXISTS %s CASCADE", tableName)));
+ @Parameters(name="DropTableWithViewsIT_multiTenant={0},
columnEncoded={1}") // name is used by failsafe as file name in reports
+ String grandChildViewDDL = "CREATE VIEW " + grandChildView
+ " AS SELECT * FROM " + childView;
+ // Wait for the tasks for dropping child views to complete. The
depth of the view tree is 2, so we expect that
+ // this will be done in two task handling runs, i.e., in tree task
handling interval at most in general
+ // by assuming that each non-root level will be processed in one
interval. To be on the safe side, we will
+ TableName linkTable =
TableName.valueOf(PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME_BYTES);
+ rs = conn.createStatement().executeQuery("SELECT * FROM " +
PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME +
+ assertTableMetaData(rs, SYSTEM_CATALOG_SCHEMA,
PhoenixDatabaseMetaData.SYSTEM_TASK_TABLE, PTableType.SYSTEM);
+ dropChildViews(env, e.getParentTenantId(),
e.getParentSchemaName(), e.getParentTableName());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectAutoCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SystemCatalogCreationOnConnectionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.monitoring.PhoenixMetricsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2107//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2107//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2107//console
This message is automatically generated.
> Cleanup metadata of child views for a base table that has been dropped
> ----------------------------------------------------------------------
>
> Key: PHOENIX-4764
> URL: https://issues.apache.org/jira/browse/PHOENIX-4764
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments:
> 0001-PHOENIX-4764-Revised-fix-based-on-the-review-comment.patch
>
>
> When we drop a base table, we no longer drop all the child view metadata.
> Clean up the child view metadata during compaction.
> If we try to recreate a base table that was previously dropped but whose
> child view metadata wasn't cleaned up throw an exception. Add a test for
> this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
