[
https://issues.apache.org/jira/browse/PHOENIX-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665872#comment-16665872
]
ASF GitHub Bot commented on PHOENIX-4997:
-----------------------------------------
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/397#discussion_r228699931
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java
---
@@ -66,74 +74,62 @@
private static List<List<Object>> result;
private long timestamp;
private String tableName;
+ private Job job;
+ private Path tmpDir;
+ private Configuration conf;
@BeforeClass
public static void doSetup() throws Exception {
Map<String,String> props = Maps.newHashMapWithExpectedSize(1);
setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
}
- @Test
- public void testMapReduceSnapshots() throws Exception {
+ @Before
--- End diff --
Refactoring done to move common code to before method.
> Phoenix MR on snapshots can produce duplicate rows
> --------------------------------------------------
>
> Key: PHOENIX-4997
> URL: https://issues.apache.org/jira/browse/PHOENIX-4997
> Project: Phoenix
> Issue Type: Bug
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
>
> Phoenix MR over snapshots uses TableSnapshotResultIterator and
> SnapshotScanner classes for iterating/scanning over snapshots. They had been
> copied over from HBase classes TableSnapshotScanner and
> ClientSideRegionScanner classes and modified according to Phoenix
> requirements. This decision was taken since some of fields of these classes
> were private and hence it was not possible to reuse them. HBASE-8369 is the
> main Jira.
> The framework had a bug which was fixed as part of HBASE-16011. However the
> fix was not ported to Phoenix and hence Phoenix MR over snapshots still
> continues to have it. This Jira is to fix that issue.
> FYI [~akshita.malhotra]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
