[ 
https://issues.apache.org/jira/browse/PHOENIX-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665987#comment-16665987
 ] 

Hadoop QA commented on PHOENIX-4997:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12945857/PHOENIX-4997.master.001.patch
  against master branch at commit 9f224a18b59fdcc323d661af3b307411c84c4a4c.
  ATTACHMENT ID: 12945857

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  private void configureJob(Job job, String tableName, String inputQuery, 
String condition, boolean shouldSplit) throws Exception {
+                              byte[] splitPoint , int expectedRegions) throws 
IOException, InterruptedException {
+      logger.info("Sleeping for 1000 ms while waiting for " + 
hbaseTableName.getNameAsString() + " to split");
+    protected static void splitRegion(TableName fullTableName, byte[] 
splitPoint) throws SQLException, IOException, InterruptedException {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectAutoCommitIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SystemCatalogCreationOnConnectionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.monitoring.PhoenixMetricsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2116//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2116//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2116//console

This message is automatically generated.

> Phoenix MR on snapshots can produce duplicate rows
> --------------------------------------------------
>
>                 Key: PHOENIX-4997
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4997
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Major
>         Attachments: PHOENIX-4997.master.001.patch
>
>
> Phoenix MR over snapshots uses TableSnapshotResultIterator and 
> SnapshotScanner classes for iterating/scanning over snapshots. They had been 
> copied over from HBase classes TableSnapshotScanner and 
> ClientSideRegionScanner classes and modified according to Phoenix 
> requirements. This decision was taken since some of fields of these classes 
> were private and hence it is not possible to reuse them. HBASE-8369 is the 
> main Jira.
> The framework had a bug which was fixed as part of HBASE-16011. However the 
> fix was not ported to Phoenix and hence Phoenix MR over snapshots still 
> continues to have it. This Jira is to fix that issue.
> FYI [~akshita.malhotra] 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to