[
https://issues.apache.org/jira/browse/PHOENIX-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669080#comment-16669080
]
ASF GitHub Bot commented on PHOENIX-4764:
-----------------------------------------
Github user kadirozde commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/399#discussion_r229407775
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -232,6 +232,7 @@ private boolean verifyMetricsFromSinkOnce(Map<String,
Long> expectedMetrics) {
long actualValue = metric.value().longValue();
if (expectedValue != actualValue) {
LOG.warn("Metric from Hadoop Sink: " +
metric.name() + " didn't match expected.");
+ LOG.warn("Expected: " + expectedValue + "
Actual: " + actualValue);
--- End diff --
I will remove it.
> Cleanup metadata of child views for a base table that has been dropped
> ----------------------------------------------------------------------
>
> Key: PHOENIX-4764
> URL: https://issues.apache.org/jira/browse/PHOENIX-4764
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments:
> 0001-PHOENIX-4764-Revised-fix-based-on-the-review-comment.patch,
> PHOENIX-4764.4.x-HBase-1.4.0001.patch, PHOENIX-4764.4.x-HBase-1.4.0002.patch,
> PHOENIX-4764.4.x-HBase-1.4.0003.patch, PHOENIX-4764.4.x-HBase-1.4.0004.patch,
> PHOENIX-4764.master.0001.patch, PHOENIX-4764.master.0002.patch,
> PHOENIX-4764.master.0003.patch, PHOENIX-4764.master.0003.patch
>
>
> When we drop a base table, we no longer drop all the child view metadata.
> Clean up the child view metadata during compaction.
> If we try to recreate a base table that was previously dropped but whose
> child view metadata wasn't cleaned up throw an exception. Add a test for
> this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
