[
https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669439#comment-16669439
]
ASF GitHub Bot commented on PHOENIX-4996:
-----------------------------------------
Github user twdsilva commented on the issue:
https://github.com/apache/phoenix/pull/401
@ChinmaySKulkarni looks pretty good. Since we always call the init()
method, it should be possible to just call the corresponding setter methods
(for tenantId, schemaName etc) and then make init() private and only call it
from the build() right? If any of the required fields haven't been set then we
could just throw an exception in the build().
> Refactor PTableImpl to use Builder Pattern
> ------------------------------------------
>
> Key: PHOENIX-4996
> URL: https://issues.apache.org/jira/browse/PHOENIX-4996
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4996.patch
>
>
> Currently _PTableImpl_ has many constructor parameters, overloaded
> constructors as well as overloaded versions of _makePTable_ which basically
> creates a new PTable itself. Because of this, constructing new PTable
> instances is becoming very difficult and error-prone. We should refactor this
> to use the builder pattern. This will improve usability and readability of
> the code at the cost of some amount of code repetition due to limitations of
> the builder pattern itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
