[
https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670563#comment-16670563
]
Hadoop QA commented on PHOENIX-4996:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12946429/PHOENIX-4996.patch
against master branch at commit 59a7dd138c661c743d58421776cb5e731e1cda99.
ATTACHMENT ID: 12946429
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ .init(table.getTenantId(), PROJECTED_TABLE_SCHEMA,
table.getName(), table.getPKName(),
+ PName defaultFamily =
PNameFactory.newName(SchemaUtil.getEmptyColumnFamily(table));
+
PTable.ImmutableStorageScheme.ONE_CELL_PER_COLUMN :
table.getImmutableStorageScheme())
+
PTable.QualifierEncodingScheme.NON_ENCODED_QUALIFIERS :
table.getEncodingScheme())
+ .init(table.getTenantId(),
table.getSchemaName(),table.getTableName(), table.getPKName(),
+ table.getBucketNum(), projectedColumns,
table.getParentSchemaName(),
+ table.getParentTableName(),
table.getIndexes(), table.getPhysicalNames(),
+ // if a TableProperty is valid on a view and is not mutable on a view
we set it to the base table value
+ // if a TableProperty is valid on a view and is mutable on a view we
use the value set on the view
+ String viewIndexSchemaName =
SchemaUtil.getSchemaNameFromFullName(viewIndexPhysicalName);
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.jdbc.SecureUserConnectionsTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2127//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2127//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2127//console
This message is automatically generated.
> Refactor PTableImpl to use Builder Pattern
> ------------------------------------------
>
> Key: PHOENIX-4996
> URL: https://issues.apache.org/jira/browse/PHOENIX-4996
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4996.patch
>
>
> Currently _PTableImpl_ has many constructor parameters, overloaded
> constructors as well as overloaded versions of _makePTable_ which basically
> creates a new PTable itself. Because of this, constructing new PTable
> instances is becoming very difficult and error-prone. We should refactor this
> to use the builder pattern. This will improve usability and readability of
> the code at the cost of some amount of code repetition due to limitations of
> the builder pattern itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
