[
https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684408#comment-16684408
]
Hudson commented on PHOENIX-4996:
---------------------------------
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2140 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2140/])
PHOENIX-4996: Refactor PTableImpl to use Builder Pattern (tdsilva: rev
11cc13b043c9d73c49134f27aef5e4c05dc6f30a)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/execute/CorrelatePlanTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PMetaDataImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/UnionCompiler.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/execute/LiteralResultIteratorPlanTest.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java
> Refactor PTableImpl to use Builder Pattern
> ------------------------------------------
>
> Key: PHOENIX-4996
> URL: https://issues.apache.org/jira/browse/PHOENIX-4996
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-4996-4.x-HBase-1.3.patch, PHOENIX-4996-v1.patch,
> PHOENIX-4996.patch
>
>
> Currently _PTableImpl_ has many constructor parameters, overloaded
> constructors as well as overloaded versions of _makePTable_ which basically
> creates a new PTable itself. Because of this, constructing new PTable
> instances is becoming very difficult and error-prone. We should refactor this
> to use the builder pattern. This will improve usability and readability of
> the code at the cost of some amount of code repetition due to limitations of
> the builder pattern itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
