[
https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673914#comment-16673914
]
Hadoop QA commented on PHOENIX-4996:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12946762/PHOENIX-4996-4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
c2d33ed384467fea4655e6f49ce43834f3886409.
ATTACHMENT ID: 12946762
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
.setTableName(PNameFactory.newName(SchemaUtil.getTableName(left.getName().getString(),
+ .setIndexes(left.getIndexes() == null ?
Collections.<PTable>emptyList() : left.getIndexes())
+
.setDefaultFamilyName(PNameFactory.newName(SchemaUtil.getEmptyColumnFamily(table)))
+ // if a TableProperty is valid on a view and is not mutable on a view
we set it to the base table value
+ // if a TableProperty is valid on a view and is mutable on a view we
use the value set on the view
+ ImmutableStorageScheme.ONE_CELL_PER_COLUMN :
baseTable.getImmutableStorageScheme())
+ QualifierEncodingScheme.NON_ENCODED_QUALIFIERS :
baseTable.getEncodingScheme())
+ String viewIndexSchemaName =
SchemaUtil.getSchemaNameFromFullName(viewIndexPhysicalName);
+ String viewIndexTableName =
SchemaUtil.getTableNameFromFullName(viewIndexPhysicalName);
+ PName viewIndexName =
PNameFactory.newName(SchemaUtil.getTableName(viewIndexSchemaName,
viewIndexTableName));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexMetadataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2139//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2139//console
This message is automatically generated.
> Refactor PTableImpl to use Builder Pattern
> ------------------------------------------
>
> Key: PHOENIX-4996
> URL: https://issues.apache.org/jira/browse/PHOENIX-4996
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Attachments: PHOENIX-4996-4.x-HBase-1.3.patch, PHOENIX-4996-v1.patch,
> PHOENIX-4996.patch
>
>
> Currently _PTableImpl_ has many constructor parameters, overloaded
> constructors as well as overloaded versions of _makePTable_ which basically
> creates a new PTable itself. Because of this, constructing new PTable
> instances is becoming very difficult and error-prone. We should refactor this
> to use the builder pattern. This will improve usability and readability of
> the code at the cost of some amount of code repetition due to limitations of
> the builder pattern itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
