[
https://issues.apache.org/jira/browse/PHOENIX-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701090#comment-16701090
]
Hadoop QA commented on PHOENIX-4983:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12949739/PHOENIX-4983-4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
0a84ad6c155b49530cf6eca9af6ed95b51ff96c2.
ATTACHMENT ID: 12949739
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "CONSTRAINT PK PRIMARY KEY(METRIC_ID))
TRANSACTION_PROVIDER='TEPHRA',TRANSACTIONAL=true";
+ } else if (!table.isImmutableRows() && connection.getSCN() != null &&
!table.getIndexes().isEmpty()) {
+ CANNOT_CREATE_TXN_TABLE_WITH_ROW_TIMESTAMP(1080, "44A11", "Cannot create a
transactional table with ROW_TIMESTAMP column."),
+ if(table != null && connection.getSCN() !=
null && !connection.isRunningUpgrade() && !connection.isBuildingIndex()) {
+
SQLExceptionCode.CANNOT_UPSERT_WITH_SCN_FOR_ROW_TIMSTAMP_COLUMN).
+ } else if(!table.isImmutableRows() &&
!table.getIndexes().isEmpty()) {
+
SQLExceptionCode.CANNOT_UPSERT_WITH_SCN_FOR_MUTABLE_TABLE_WITH_INDEXES).
+ if (plan.getTargetRef() != null && table !=
null && table.isTransactional()) {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2172//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2172//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2172//console
This message is automatically generated.
> Allow using a connection with a SCN set to write data to tables EXCEPT
> transactional tables or mutable tables with indexes or tables with a
> ROW_TIMESTAMP column
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4983
> URL: https://issues.apache.org/jira/browse/PHOENIX-4983
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Thomas D'Silva
> Assignee: Swaroopa Kadam
> Priority: Major
> Labels: SFDC
> Attachments: PHOENIX-4983-4.x-HBase-1.4.patch
>
>
> Currently If a SCN is set on a connection it is read-only. We only need to
> prevent a client from using a connection with a SCN set to upsert data for:
> 1) transactional tables
> 2) mutable tables with indexes
> 3) tables with a ROW_TIMESTAMP column
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
