[ 
https://issues.apache.org/jira/browse/PHOENIX-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709183#comment-16709183
 ] 

ASF GitHub Bot commented on PHOENIX-4983:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/405#discussion_r238808013
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java 
---
    @@ -459,7 +459,18 @@ public SQLException newException(SQLExceptionInfo 
info) {
         MAX_MUTATION_SIZE_EXCEEDED(729, "LIM01", "MutationState size is bigger 
than maximum allowed number of rows"),
         MAX_MUTATION_SIZE_BYTES_EXCEEDED(730, "LIM02", "MutationState size is 
bigger than maximum allowed number of bytes"), 
         INSUFFICIENT_MEMORY(999, "50M01", "Unable to allocate enough memory."),
    -    HASH_JOIN_CACHE_NOT_FOUND(900, "HJ01", "Hash Join cache not found");
    +    HASH_JOIN_CACHE_NOT_FOUND(900, "HJ01", "Hash Join cache not found"),
    +
    +    CANNOT_UPSERT_WITH_SCN_FOR_ROW_TIMSTAMP_COLUMN(901,"43M12",
    +            "Cannot use a connection with SCN set to upsert data for " +
    +                    "table with ROW_TIMESTAMP column."),
    +    CANNOT_UPSERT_WITH_SCN_FOR_TXN_TABLE(902,"43M13",
    --- End diff --
    
    remove this as its not used


> Allow using a connection with a SCN set to write data to tables EXCEPT 
> transactional tables or mutable tables with indexes or tables with a 
> ROW_TIMESTAMP column
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4983
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4983
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>            Assignee: Swaroopa Kadam
>            Priority: Major
>              Labels: SFDC
>         Attachments: PHOENIX-4983-4.x-HBase-1.4.patch
>
>
> Currently If a SCN is set on a connection it is read-only. We only need to 
> prevent a client from using a connection with a SCN set to upsert data for:
> 1) transactional tables 
> 2) mutable tables with indexes 
> 3) tables with a ROW_TIMESTAMP column



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to