[
https://issues.apache.org/jira/browse/PHOENIX-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729617#comment-16729617
]
Lars Hofhansl commented on PHOENIX-5082:
----------------------------------------
In UpsertCompiler I see this:
{code}
// Commit a batch if auto commit is true and we're at our batch
size
if (isAutoCommit && rowCount % batchSize == 0) {
MutationState state = new MutationState(tableRef, mutation,
0, maxSize, maxSizeBytes, connection);
connection.getMutationState().join(state);
connection.getMutationState().send();
mutation.clear();
}
{code}
This is interesting now with transactions. The meaning of commit is different
now.
With transaction I mostly want to have autocommit off, yet I'd want to send
changes to HBase as soon as a batch has filled up... When we have a separate
transaction processor edits should be send to HBase immediately when a batch
has filled.
I don't know whether rollback would still work in that case... Need to think
about this.
> Observations about the Phoenix-Omid integration
> -----------------------------------------------
>
> Key: PHOENIX-5082
> URL: https://issues.apache.org/jira/browse/PHOENIX-5082
> Project: Phoenix
> Issue Type: Task
> Reporter: Lars Hofhansl
> Assignee: Yonatan Gottesman
> Priority: Major
> Attachments: Omid-profile.png, Omid-sample.png
>
>
> Filing this issue to track my observations and perhaps some fixes.
> [~ohads]
> [~jamestaylor]
> [~yonigo]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
