[
https://issues.apache.org/jira/browse/PHOENIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730570#comment-16730570
]
Hadoop QA commented on PHOENIX-4009:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12953272/PHOENIX-4009.4.x-HBase-1.4.001.patch
against 4.x-HBase-1.4 branch at commit
57509506dd64f67265473ac9daa30d9756e211d6.
ATTACHMENT ID: 12953272
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public NamespaceDisabledStatsCollectorIT(boolean
userTableNamespaceMapped, boolean collectStatsOnSnapshot) {
+ public NamespaceEnabledStatsCollectorIT(boolean userTableNamespaceMapped,
boolean collectStatsOnSnapshot) {
+ protected BaseStatsCollectorIT(boolean userTableNamespaceMapped, boolean
collectStatsOnSnapshot) {
+ protected BaseStatsCollectorIT(boolean mutable, String
transactionProvider, boolean columnEncoded) {
+ boolean userTableNamespaceMapped, boolean
columnEncoded, boolean collectStatsOnSnapshot) {
+
sb.append(",IMMUTABLE_STORAGE_SCHEME="+PTableImpl.ImmutableStorageScheme.ONE_CELL_PER_COLUMN);
+ serverProps.put(QueryServices.STATS_GUIDEPOST_WIDTH_BYTES_ATTRIB,
Long.toString(defaultGuidePostWidth));
+ clientProps.put(QueryServices.STATS_GUIDEPOST_WIDTH_BYTES_ATTRIB,
Long.toString(defaultGuidePostWidth));
+ setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()),
new ReadOnlyProps(clientProps.entrySet().iterator()));
+ physicalTableName = SchemaUtil.getPhysicalHBaseTableName(schemaName,
tableName, userTableNamespaceMapped).getString();
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.monitoring.PhoenixMetricsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MapReduceIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2224//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2224//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2224//console
This message is automatically generated.
> Run UPDATE STATISTICS command by using MR integration on snapshots
> ------------------------------------------------------------------
>
> Key: PHOENIX-4009
> URL: https://issues.apache.org/jira/browse/PHOENIX-4009
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Karan Mehta
> Priority: Major
> Attachments: PHOENIX-4009.4.x-HBase-1.4.001.patch
>
>
> Now that we have the capability to run queries against table snapshots
> through our map reduce integration, we can utilize this capability for stats
> collection too. This would make our stats collection more resilient, resource
> aware and less resource intensive. The bulk of the plumbing is already in
> place. We would need to make sure that the integration doesn't barf when the
> query is an UPDATE STATISTICS command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
