[
https://issues.apache.org/jira/browse/PHOENIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753919#comment-16753919
]
Hadoop QA commented on PHOENIX-4009:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12956540/PHOENIX-4009.master.003.patch
against master branch at commit 573ec9f73a86d236a6e69a2bac23f177a29f3c44.
ATTACHMENT ID: 12956540
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ protected BaseStatsCollectorIT(boolean userTableNamespaceMapped,
boolean collectStatsOnSnapshot) {
+ protected BaseStatsCollectorIT(boolean mutable, String
transactionProvider, boolean columnEncoded) {
+ boolean userTableNamespaceMapped, boolean
columnEncoded, boolean collectStatsOnSnapshot) {
+ updateStatisticsSql += " SET \"" +
QueryServices.STATS_GUIDEPOST_WIDTH_BYTES_ATTRIB + "\" = " + guidePostWidth;
+ String guidePostWidth, String
localPhysicalTableName) throws Exception {
+ LOG.info("Successfully created snapshot " + snapshotName + " for " +
localPhysicalTableName);
+ conn.createStatement().execute("ALTER TABLE " + fullTableName + "
SET GUIDE_POSTS_WIDTH = " + guidePostWidth);
+ String q = "SELECT SUM(GUIDE_POSTS_ROW_COUNT) FROM SYSTEM.STATS
WHERE PHYSICAL_NAME = '" + physicalTableName + "'";
+ conn.createStatement().executeUpdate("DELETE FROM SYSTEM.STATS
WHERE PHYSICAL_NAME = '" + physicalTableName + "'");
+ q = "SELECT SUM(GUIDE_POSTS_ROW_COUNT) FROM SYSTEM.STATS WHERE
PHYSICAL_NAME = '" + physicalTableName + "'";
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NullIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UngroupedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.Array1IT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ExplainPlanWithStatsDisabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DistinctPrefixFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DateTimeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.salted.SaltedTableUpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryWithOffsetIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AggregateIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2274//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2274//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2274//console
This message is automatically generated.
> Run UPDATE STATISTICS command by using MR integration on snapshots
> ------------------------------------------------------------------
>
> Key: PHOENIX-4009
> URL: https://issues.apache.org/jira/browse/PHOENIX-4009
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Karan Mehta
> Priority: Major
> Labels: stats, statsCollection
> Attachments: PHOENIX-4009.4.x-HBase-1.4.001.patch,
> PHOENIX-4009.4.x-HBase-1.4.002.patch,
> PHOENIX-4009.4.x-HBase-1.4.003.addendum.patch, PHOENIX-4009.master.001.patch,
> PHOENIX-4009.master.002.patch, PHOENIX-4009.master.003.patch
>
> Time Spent: 13h 20m
> Remaining Estimate: 0h
>
> Now that we have the capability to run queries against table snapshots
> through our map reduce integration, we can utilize this capability for stats
> collection too. This would make our stats collection more resilient, resource
> aware and less resource intensive. The bulk of the plumbing is already in
> place. We would need to make sure that the integration doesn't barf when the
> query is an UPDATE STATISTICS command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
