karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r245095959
########## File path: pom.xml ########## @@ -0,0 +1,553 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.phoenix</groupId> + <artifactId>phoenix-queryserver</artifactId> + <version>4.15.0-HBase-1.4-SNAPSHOT</version> Review comment: Yeah, we may not need that. I think we can put a default version of phoenix and override others at runtime for those branches. I believe such a behavior is possible with maven and builds can be setup accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
