karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r246191556
########## File path: pom.xml ########## @@ -0,0 +1,553 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.phoenix</groupId> + <artifactId>phoenix-queryserver</artifactId> + <version>4.15.0-HBase-1.4-SNAPSHOT</version> Review comment: Here's what I am saying. This project will be versioned from `1.0.0-SNAPSHOT`. The project will have a phoenix.version property which will define the versions of phoenix it will use (phoenix-core) This value will be defaulted to `4.14.1-HBase-1.4` (Doing so will cause compilation failure since we have a patch in 4.15 (PHOENIX-4755) here, so we need to discuss this) The compilation can be carried out with `mvn clean install -DskipTests -Dphoenix.version=4.15.0-HBase-1.4-SNAPSHOT` or any other version as deemed appropriate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
