BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r246943389
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
##########
@@ -154,7 +154,8 @@
public enum SchemaType {
TABLE,
- QUERY;
+ QUERY,
+ UPDATE_STATS
Review comment:
If you check the usages of SchemaType in the whole code base, you'll find
SchemaType is mainly used by Phoenix-Pig and has its specific meaning in
Phoenix-Pig. TABLE and QUERY maps to two PhoenixHBaseLoader scheme
"hbase://table/" and "hbase://query", and it also maps to corresponding
resource schema in Phoenix-Pig. That's why it seems to a big idea to define new
schema type and pollute its usage in Phoenix_Pig. I prefer to add a new
configuration or new Parameter in PhoenixMapReduceUtil.setInput to indicate
this is UPDATE_STATISTICS MR job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
