BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run
UPDATE STATISTICS command by using MR integration on…
URL: https://github.com/apache/phoenix/pull/419#discussion_r247591466
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
##########
@@ -154,7 +154,8 @@
public enum SchemaType {
TABLE,
- QUERY;
+ QUERY,
+ UPDATE_STATS
Review comment:
This is my last concern about your change. I object to reuse SchemaType for
indicating UPDATE_STATISTICS MR job, because we need to keep logical
independence of data structure and data type. I don't want to block your
progress on your work. If you insist on making this change, you can ignore my
comment and proceed with commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
