twdsilva commented on a change in pull request #428: PHOENIX-374: Enable access 
to dynamic columns in * or cf.* selection
URL: https://github.com/apache/phoenix/pull/428#discussion_r250335600
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ##########
 @@ -934,6 +938,20 @@ private void addCoprocessors(byte[] tableName, 
TableDescriptorBuilder builder, P
                     }
                 }
             }
+
+            boolean wildcardIncludesDynamicCols = props.getBoolean(
+                    WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB, 
DEFAULT_WILDCARD_QUERY_DYNAMIC_COLS_ATTRIB);
+            // We register the coprocessor for dynamic columns to be exposed 
when issuing wildcard
 
 Review comment:
   We need need to always load this coprocessor, since you could have a mix of 
clients that have this config turned on/off.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to