twdsilva commented on a change in pull request #428: PHOENIX-374: Enable access
to dynamic columns in * or cf.* selection
URL: https://github.com/apache/phoenix/pull/428#discussion_r250306540
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java
##########
@@ -501,7 +516,9 @@ public static RowProjector compile(StatementContext
context, SelectStatement sta
// Ignore as this can happen for local indexes when the data
table has a column family, but there are no covered columns in the family
}
}
- return new RowProjector(projectedColumns, Math.max(estimatedKeySize,
estimatedByteSize), isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard);
+ return new RowProjector(projectedColumns, Math.max(estimatedKeySize,
estimatedByteSize),
+ isProjectEmptyKeyValue, resolver.hasUDFs(), isWildcard,
+ isWildcard || !projectedFamilies.isEmpty());
Review comment:
do you need to include the isWildcard boolean check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
