[
https://issues.apache.org/jira/browse/PHOENIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757590#comment-16757590
]
Hadoop QA commented on PHOENIX-5112:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12957139/5112-master.txt
against master branch at commit 8a0eb3e5e62e168581c8c0732519c1f0d8027121.
ATTACHMENT ID: 12957139
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.util.CoprocessorHConnectionTableFactoryTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2290//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2290//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2290//console
This message is automatically generated.
> Simplify QueryPlan selection in Phoenix.
> ----------------------------------------
>
> Key: PHOENIX-5112
> URL: https://issues.apache.org/jira/browse/PHOENIX-5112
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Priority: Major
> Attachments: 5112-master.txt, 5112-master.txt
>
>
> Brought to light in part in PHOENIX-5109, plan selection in Phoenix is too
> complicated with its logic spread over multiple areas. My recent changes let
> most index through the initial filters and next step is to put all the logic
> in {{QueryOptimizer.orderPlansBestToWorst}}.
> One exception is plans with global indexes for queries with uncovered
> queries, those should still be handled in {{addPlan}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
