[ 
https://issues.apache.org/jira/browse/PHOENIX-5112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847911#comment-16847911
 ] 

Thomas D'Silva commented on PHOENIX-5112:
-----------------------------------------

+1 LGTM. 
[~jamestaylor] The tests are passing on the 4.14 branches. I will file JIRAs to 
fix the tests failing on the 4.x and master branches so that we can get 4.15 
released.

> Simplify QueryPlan selection in Phoenix.
> ----------------------------------------
>
>                 Key: PHOENIX-5112
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5112
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Priority: Major
>         Attachments: 5112-master.txt, 5112-master.txt
>
>
> Brought to light in part in PHOENIX-5109, plan selection in Phoenix is too 
> complicated with its logic spread over multiple areas. My recent changes let 
> most index through the initial filters and next step is to put all the logic 
> in {{QueryOptimizer.orderPlansBestToWorst}}.
> One exception is plans with global indexes for queries with uncovered 
> queries, those should still be handled in {{addPlan}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to