[ 
https://issues.apache.org/jira/browse/PHOENIX-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759221#comment-16759221
 ] 

Lars Hofhansl edited comment on PHOENIX-5120 at 2/2/19 10:27 PM:
-----------------------------------------------------------------

Turns out there's not a single test that tests the use of sort spooling. Only 
the SpoolingIterator is tested, which uses a different spooling mechanism. 
Sigh. (At least I couldn't find any).

I ran SpooledTmpFileDeleteIT, but it does not test ORDER BY spooling.


was (Author: lhofhansl):
Turns out there's not a single test that tests the use of sort spooling. Only 
the SpoolingIterator is tested, which uses a different spooling mechanism. 
Sigh. (At least I couldn't find any).

> Avoid using MappedByteBuffers for server side sorting.
> ------------------------------------------------------
>
>                 Key: PHOENIX-5120
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5120
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Lars Hofhansl
>            Priority: Major
>         Attachments: 5120-1.4-wip.txt
>
>
> We should had a production outage due to this.
> MappedByteBuffer may leave files around, on top they use direct memory, which 
> is not cleared until the JVM executes a full GC.
> See last comment on PHOENIX-2405.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to