[
https://issues.apache.org/jira/browse/PHOENIX-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760548#comment-16760548
]
Lars Hofhansl edited comment on PHOENIX-5120 at 2/5/19 8:08 AM:
----------------------------------------------------------------
One thing is I just noticed... It's better to use
DataInputStream.readFully(...) rather than read(...)
I'll make that change tomorrow, rest is unchanged.
was (Author: lhofhansl):
One thing is I just noticed... It's better to use
DataInputStream.readFully(...) rather than read(...)
> Avoid using MappedByteBuffers for server side sorting.
> ------------------------------------------------------
>
> Key: PHOENIX-5120
> URL: https://issues.apache.org/jira/browse/PHOENIX-5120
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 4.14.1
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 4.15.0, 5.1.0
>
> Attachments: 5120-1.4-v2.txt, 5120-1.4-v3.txt, 5120-1.4-wip.txt,
> 5120-1.4.txt, 5120-master-v3.txt, 5120-master-v5.txt, 5120-master-v6.txt,
> 5120-master.txt
>
>
> We should had a production outage due to this.
> MappedByteBuffer may leave files around, on top they use direct memory, which
> is not cleared until the JVM executes a full GC.
> See last comment on PHOENIX-2405.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
