kadirozde commented on a change in pull request #434: PHOENIX-5018 Index
mutations created by UPSERT SELECT will have wrong…
URL: https://github.com/apache/phoenix/pull/434#discussion_r256645570
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java
##########
@@ -211,23 +211,14 @@ public Void run() throws Exception {
// we should be able to read the data from another index as well
to which we have not given any access to
// this user
- verifyAllowed(createIndex(indexName2, phoenixTableName),
unprivilegedUser);
Review comment:
Currently global indexes are built by using UPSERT SELECT, i..e, by reading
mutations from the data table and writing the corresponding mutations to the
index table. The user does not need to have the write privilege on the data
table in order to build an index table. However, in the new approach, an index
table is built by replaying the existing mutations back on the data table again
(without actually applying them to the data table) for the purpose of
reconstructing the index mutations. Such replay attempts are allowed only when
the user has the write privilege. Therefore, I had to delete the scenarios that
are not applicable anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
