kadirozde commented on a change in pull request #434: PHOENIX-5018 Index
mutations created by UPSERT SELECT will have wrong…
URL: https://github.com/apache/phoenix/pull/434#discussion_r257084097
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -1741,6 +1743,13 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
if (connection.getSCN() != null) {
return buildIndexAtTimeStamp(table, statement.getTable());
}
+
+ String dataTableFullName = SchemaUtil.getTableName(
+ tableRef.getTable().getSchemaName().getString(),
+ tableRef.getTable().getTableName().getString());
Review comment:
I needed this for the initial version of the compiler where the index table
was searched in the index list of the PTable for the data table. MetadataClient
constructs the PTable object for the data table before the index table is
created and thus the object does have a reference to the newly created index.
The complier has changed and this search was eliminated. So there is no need to
refresh the PTable object anymore. I will remove the refresh code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
